Make Code-Review label values' meaning clear to non-maintainers
Currently the labels look like a direct suggestion to a maintainer
dealing with the change, but even being interpreted this way, -1 label
sounds strange as "didn't submit" doesn't match the fact nobody has
submitted anything yet.
What's worse, new contributors have every right to assume that the
message is addressing them, and upon receiving an email saying "I
would prefer you didn't submit this" they mistakenly think that the
word "submit" refers to their action of posting for review, there's
nothing to indicate this part is directed to the maintainer. Also,
most people have never seen the "Submit" button, that's a process
detail known to the maintainers but not the general public.
This is confirmed by real-life observations of contributors to the
OpenOCD project, I know at least three persons who got somewhat
offended by receiving such a message from the review system.
Change-Id: I035a615a6caf6e085edd5827f3bfe33342156324
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
diff --git a/Documentation/config-labels.txt b/Documentation/config-labels.txt
index 67ebcf5..fc25f22 100644
--- a/Documentation/config-labels.txt
+++ b/Documentation/config-labels.txt
@@ -19,7 +19,7 @@
The range of values is:
-* -2 Do not submit
+* -2 This shall not be merged
+
The code is so horribly incorrect/buggy/broken that it must not be
submitted to this project, or to this branch. This value is valid
@@ -29,7 +29,7 @@
+
*Any -2 blocks submit.*
-* -1 I would prefer that you didn't submit this
+* -1 I would prefer this is not merged as is
+
The code doesn't look right, or could be done differently, but
the reviewer is willing to live with it as-is if another reviewer
