Google Git
Sign in
gerrit / gerrit / 2374b6b18418ca7b5c6b4aa26031ef00bda025c7
commit2374b6b18418ca7b5c6b4aa26031ef00bda025c7[log] [tgz]
authorOle Rehmsen <oler@google.com>Tue Jul 02 16:06:22 2019 +0200
committerOle Rehmsen <oler@google.com>Mon Jul 08 17:11:47 2019 +0200
treec465568b2f07f369e00885f0ff60419d3a100761
parent8eac3ad7cb98862c267767efa8c2ac07ef88ccd1 [diff]
Interpret empty DiffIntralineInfo list as marked

This will treat `edit_a/b` set to empty lists the same as them not being
set at all:
The entire chunk, including the empty space after the last character in
the line, is rendered in dark diff background colors.

Before: https://imgur.com/a/xSI7gq9
After: https://imgur.com/a/Hp8jxYq

Currently, the Gerrit API (to the best of my knowledge) never returns an
empty DiffIntralineInfo list. However, gr-diff, which uses the same type
as an input, has to decide how to handle this situation.

The Polygerrit UI does not currently expose nor respect the
intraline_difference parameter
(https://bugs.chromium.org/p/gerrit/issues/detail?id=8088),
and this is a step towards that.

Change-Id: I603fc2d1ef49c7bc490b28cea93b88556626cb5a
3 files changed
tree: c465568b2f07f369e00885f0ff60419d3a100761
  1. .settings/
  2. antlr3/
  3. contrib/
  4. Documentation/
  5. java/
  6. javatests/
  7. lib/
  8. plugins/
  9. polygerrit-ui/
  10. prolog/
  11. prologtests/
  12. proto/
  13. resources/
  14. tools/
  15. webapp/
  16. .bazelproject
  17. .bazelrc
  18. .bazelversion
  19. .editorconfig
  20. .git-blame-ignore-revs
  21. .gitignore
  22. .gitmodules
  23. .mailmap
  24. .pydevproject
  25. BUILD
  26. COPYING
  27. INSTALL
  28. package.json
  29. README.md
  30. SUBMITTING_PATCHES
  31. version.bzl
  32. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.