| commit | 23518c060a6d4691590bec31bc712053d908a97d | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Wed Feb 08 10:14:39 2023 +0100 |
| committer | Edwin Kempin <ekempin@google.com> | Wed Feb 08 10:14:39 2023 +0100 |
| tree | bd9cf275ad68860bd01ee7f9b4c29a776525df37 | |
| parent | cb15b829ee1f022675fda1715ef76ea14a620812 [diff] |
Don't add owner to attention set on merged change if bot votes negatively Bot actions don't update the attention set, except if they apply a negative vote. Bots can also apply (or more correctly re-apply) negative votes on merged changes, which currently leads to an unwanted attention set update (due to the negative bot vote the owner is added back to the attention set). This is unwanted since this change is already merged and there is nothing to do for the owner. If a change is merged we do not allow downgrades of votes, including applying negative votes if a vote was not present yet (as this would be a downgrade from 0 to the negative vote). However if the negative vote is already present on submit (e.g. on an old patch set or a non-blocking label), the same negative vote can be re-applied on the merged change (since it's not changing the vote, it's not a downgrade). Release-Notes: Don't add owner to attention set on merged change if bot re-applies a negative vote Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I7e9b8ea6bb4fd9a05d06814f85900325635da0d5
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.