| commit | 22f4e92288ac07a679765c62000068d2fa8a7aed | [log] [tgz] |
|---|---|---|
| author | Kamil Musin <kamilm@google.com> | Wed Mar 27 17:26:16 2024 +0100 |
| committer | Kamil Musin <kamilm@google.com> | Thu Mar 28 12:40:08 2024 +0100 |
| tree | 43a3742ecf2153be8f177f577e7b6e1cd1193b68 | |
| parent | 1070800279e56f465ffb6ad0e792092166ec82aa [diff] |
Improve change-model load change consistency 1. Only update the change if change is undefined, or if the change number is the same: There must be a consistency between ChangeViewModel and ChangeModel. Only change to a ChangeViewModel is allowed to change the changeNum, while all other calls to updateStateChange can only update the info of the current change to a more recent one. The update through rxjs can load a different change since updateLoadingState sets the change to undefined. 2. Simplify LoadingState and remove RELOADING: RELOADING state previously could only happen as the result of a following race condition ChangeViewModel forceLoad sets changNum to undefined and then async schedules setting it back to the original state. The RELOADING is only set if the processing of restApi results (no actual calls are performed since changeNum is undefined) is scheduled later in the Event Queue than the restoration of the original state. Moreover the actual difference between LOADING and RELOADING never matters in code. We simplify the logic by removing RELOADING state. Passing a undefined changeNum, will immediately set the change to undefined and LoadingState to NOT_LOADED. Previously it would be "change is undefined", loading state "LOADED", until it changes to "NOT_LOADED" in the next Event Queue cycle (or "RELOADING" if the race is won by the forceLoad) 3. Move updateRevisionsWithCommitShas into updateStateChange: This makes the state more consistent. Now the change in ChangeModel always has the values set, regardless whether the value came from a manual call or subscription. 4. Add catchError, to reset LoadingState if the RestApi calls throw an error Google-Bug-Id: b/328632912 Release-Notes: skip Change-Id: I0ed368df7152150ed974c0b337894758ee531344
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.