| commit | 22145cb21b9346c2a60bf4e8dd97f4a44606de4e | [log] [tgz] |
|---|---|---|
| author | Nasser Grainawi <nasser.grainawi@linaro.org> | Fri Apr 05 16:55:41 2024 -0600 |
| committer | Nasser Grainawi <nasser.grainawi@linaro.org> | Tue Apr 09 12:33:52 2024 -0600 |
| tree | 80cd508892241a73f4537556769ffdeeefc418c8 | |
| parent | 133a676ecda316f8cfe2325af7a6a8de4deb1b3c [diff] |
Ensure plugin modules are bound in the baseInjector It's required to do an explicit bind when using child injectors in order to prevent just-in-time bindings from being promoted to an ancestor injector. This is a well documented issue in Guice [1] that is only mentioned a couple places in the javadocs, most prominently at [2]. In Gerrit this became a problem with the introduction of the plugin ApiModule. That module is expected to be the base for other plugins, but shouldn't get any bindings promoted from the per-plugin ServerPluginInfoModule. Adding explicit bind() calls in ServerPluginInfoModule for each of the plugin modules prevents that from happening, as seen in the new PluginBindingsIT suite. Also fix an issue with creating child injectors using a buggy Optional.orElse() pattern when creating the new root injector for a plugin. This was causing two new injectors to always be created for the ServerPluginInfoModule. [1] https://github.com/google/guice/issues/973 [2] https://google.github.io/guice/api-docs/latest/javadoc/com/google/inject/Injector.html#createChildInjector(java.lang.Iterable) Bug: Issue 332512505 Change-Id: I8633083d97d28ea9d1e61a90bb86efdb399c12d0 Release-Notes: Fix installing plugins injecting the injector when an ApiModule plugin is also installed
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.