| commit | 21aac1d27d9edd58a17e4ce4d9ccb163cb930513 | [log] [tgz] |
|---|---|---|
| author | David Ostrovsky <david@ostrovsky.org> | Sat Jan 08 16:21:56 2022 +0100 |
| committer | David Ostrovsky <david@ostrovsky.org> | Sat Jan 08 16:25:13 2022 +0100 |
| tree | 215c7e76bfbd7d0918e2820a4c5dd8e94d10f487 | |
| parent | 9536ac99099f0e16283bde01dddf22b4e12cd4d4 [diff] |
Fix FloggerStringConcatenation bug pattern flagged by error prone Change-Id: I681694dccc0679c850f9eb43337307eb49e59220 Details: https://errorprone.info/bugpattern/FloggerStringConcatenation
diff --git a/java/com/google/gerrit/httpd/auth/openid/OpenIdServiceImpl.java b/java/com/google/gerrit/httpd/auth/openid/OpenIdServiceImpl.java index b685011..c655b6c 100644 --- a/java/com/google/gerrit/httpd/auth/openid/OpenIdServiceImpl.java +++ b/java/com/google/gerrit/httpd/auth/openid/OpenIdServiceImpl.java
@@ -172,7 +172,7 @@ aReq.addExtension(pape); } } catch (MessageException | ConsumerException e) { - logger.atSevere().withCause(e).log("Cannot create OpenID redirect for %s" + openidIdentifier); + logger.atSevere().withCause(e).log("Cannot create OpenID redirect for %s", openidIdentifier); return new DiscoveryResult(DiscoveryResult.Status.ERROR); }
diff --git a/java/com/google/gerrit/server/git/MultiProgressMonitor.java b/java/com/google/gerrit/server/git/MultiProgressMonitor.java index 7e5c99f..15fbe3f 100644 --- a/java/com/google/gerrit/server/git/MultiProgressMonitor.java +++ b/java/com/google/gerrit/server/git/MultiProgressMonitor.java
@@ -161,7 +161,7 @@ volatileTotal.addAndGet(workUnits); } else { logger.atWarning().log( - "Total work has been finalized on sub-task " + getName() + " and cannot be updated"); + "Total work has been finalized on sub-task %s and cannot be updated", getName()); } }