2148bf294d662bc73a7724855ba22c3530e9ed22 - gerrit

commit: 2148bf294d662bc73a7724855ba22c3530e9ed22
[log]
author: Dave Borowitz <dborowitz@google.com>
Wed Aug 06 09:46:49 2014 -0700
committer: Dave Borowitz <dborowitz@google.com>
Thu Aug 07 10:41:18 2014 -0700
tree: e5c641ab33730fc215a82732a96ffecee95fa067
parent: cf31c84e8a1b082fe668bb10a19955656d8ddfd1 [diff]

Acceptance tests: Always check error after SshSession.exec()

The GitUtil.createProject() method in particular was failing silently
in a surprising number of cases. Fix all of these, and add the error
message to the AssertionError in cases where it was checked.

Change-Id: Ibca7881edfe8be583a19cc08f2b942bf4a9bbfc3

gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/GitUtil.java[diff]
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/git/SubmitOnPushIT.java[diff]
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/git/VisibleRefFilterIT.java[diff]
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/group/DefaultGroupsIT.java[diff]
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/rest/project/ProjectLevelConfigIT.java[diff]
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/ssh/BanCommitIT.java[diff]
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/ssh/GarbageCollectionIT.java[diff]

7 files changed