commit | 36367e17f95aa70989ba19eee04eda8930796452 | [log] [tgz] |
---|---|---|
author | Edwin Kempin <ekempin@google.com> | Fri Jul 23 09:54:34 2021 +0200 |
committer | Edwin Kempin <ekempin@google.com> | Fri Jul 23 10:14:17 2021 +0200 |
tree | de7aa2f4ef8967c4c32d5d60ca2d4afa902492c5 | |
parent | 3dd108dee7775bd56022b735b9ac59d34cf5056e [diff] |
Add interface that allows Gerrit to check whether a request is cancelled At the moment Gerrit doesn't get to know when a client disconnects until the response is written. This means that requests continue to run even if the is client is no longer waiting for a response. This is bad, especially for very long-running requests, as these requests keep server threads occupied. If there is an issue with a certain endpoint or repository and requests get stuck, this can cause the server running out of threads so that all users get blocked. To avoid this situation Gerrit should be able to recognize if the client disconnected and then abort the request to free up the thread. This may not be possible for all kind of requests (e.g. HTTP requests) but where possible we want to make it work. This change is the first step towards this goal. The interface is designed in such a way that it's possible to return a reason for the cancellation. This allows to differentiate between cancellations from the user and cancellations due to exceeded deadlines. Note, the RequestStateProvider interface is not a regular extension point where extensions can be registered via Guice. Instead implementations will be stored in a ThreadLocal variable so that they are accessible during the request execution. Since requests will need to check often whether the request is cancelled, it's better to avoid any overhead that comes with injecting extension point implementations via Guice. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: Ie1b7d337fbd4bbdd8f426ac111ea28ec88066722
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.