commit 1face66f6a777033740be40f2c9b133e5ccdd957
author Ben Rohlfs <brohlfs@google.com> Thu Nov 03 18:41:02 2022 +0100
committer Ben Rohlfs <brohlfs@google.com> Mon Nov 07 11:47:15 2022 +0100
tree 5d74a3f9e3afa03d4cb1eb122f0af35c7dfa7c71
parent 5a3fd07589ca67082b7471ec2594c2f68b8d51e4

Fix gr-diff-text tests

The checks were not awaited, so the failures were swallowed.

Release-Notes: skip
Change-Id: I0f36366b631e3d5f5dc7414b41c16410f245f145

polygerrit-ui/app/embed/diff/gr-diff-builder/gr-diff-text_test.ts

diff --git a/polygerrit-ui/app/embed/diff/gr-diff-builder/gr-diff-text_test.ts b/polygerrit-ui/app/embed/diff/gr-diff-builder/gr-diff-text_test.ts
index 6814fdf..aec7fe0 100644
--- a/polygerrit-ui/app/embed/diff/gr-diff-builder/gr-diff-text_test.ts
+++ b/polygerrit-ui/app/embed/diff/gr-diff-builder/gr-diff-text_test.ts
@@ -18,8 +18,9 @@
   let element: GrDiffText;
 
   setup(async () => {
-    element = await fixture<GrDiffText>(html`<gr-diff-text></gr-diff-text>`);
-    await element.updateComplete;
+    element = await fixture<GrDiffText>(
+      html`<gr-diff-text tabsize="4" linelimit="10"></gr-diff-text>`
+    );
   });
 
   const check = async (
@@ -28,20 +29,18 @@
     ignoreAttributes: string[] = []
   ) => {
     element.text = text;
-    element.tabSize = 4;
-    element.lineLimit = 10;
     await element.updateComplete;
     assert.lightDom.equal(element, html, {ignoreAttributes});
   };
 
   suite('lit rendering', () => {
-    test('renderText newlines 1', () => {
-      check('abcdef', 'abcdef');
-      check('a'.repeat(20), `aaaaaaaaaa${LINE_BREAK}aaaaaaaaaa`);
+    test('renderText newlines 1', async () => {
+      await check('abcdef', 'abcdef');
+      await check('a'.repeat(20), `aaaaaaaaaa${LINE_BREAK}aaaaaaaaaa`);
     });
 
-    test('renderText newlines 2', () => {
-      check(
+    test('renderText newlines 2', async () => {
+      await check(
         '<span class="thumbsup">👍</span>',
         '&lt;span clas' +
           LINE_BREAK +
@@ -53,8 +52,8 @@
       );
     });
 
-    test('renderText newlines 3', () => {
-      check(
+    test('renderText newlines 3', async () => {
+      await check(
         '01234\t56789',
         '01234' + TAB + '56' + LINE_BREAK + '789',
         TAB_IGNORE
@@ -64,7 +63,7 @@
     test('renderText newlines 4', async () => {
       element.lineLimit = 20;
       await element.updateComplete;
-      check(
+      await check(
         '👍'.repeat(58),
         '👍'.repeat(20) +
           LINE_BREAK +
@@ -75,10 +74,11 @@
     });
 
     test('tab wrapper style', async () => {
+      element.lineLimit = 100;
       for (const size of [1, 3, 8, 55]) {
         element.tabSize = size;
         await element.updateComplete;
-        check(
+        await check(
           '\t',
           /* HTML */ `
             <span
@@ -91,18 +91,18 @@
       }
     });
 
-    test('tab wrapper insertion', () => {
-      check('abc\tdef', 'abc' + TAB + 'def', TAB_IGNORE);
+    test('tab wrapper insertion', async () => {
+      await check('abc\tdef', 'abc' + TAB + 'def', TAB_IGNORE);
     });
 
     test('escaping HTML', async () => {
       element.lineLimit = 100;
       await element.updateComplete;
-      check(
+      await check(
         '<script>alert("XSS");<' + '/script>',
         '&lt;script&gt;alert("XSS");&lt;/script&gt;'
       );
-      check('& < > " \' / `', '&amp; &lt; &gt; " \' / `');
+      await check('& < > " \' / `', '&amp; &lt; &gt; " \' / `');
     });
 
     test('text length with tabs and unicode', async () => {