commit 1d1287f7f4345dae7a6562f5f9deb17c3ef2d69f
author Edwin Kempin <ekempin@google.com> Mon Dec 10 15:36:08 2018 +0100
committer Dave Borowitz <dborowitz@google.com> Mon Dec 10 16:03:26 2018 -0800
tree 2957e0e52546dc89696f921f6c50f573ccb3335e
parent 1c80a80ef0d131beebb50ae81b8a6d13fcba8d18

ConsistencyChecker: Remove support for deleting patch sets from ReviewDb

ReviewDb is gone.

Change-Id: I81ee429c4d024be8f6e1dec4695046515ecac980
Signed-off-by: Edwin Kempin <ekempin@google.com>

java/com/google/gerrit/server/change/ConsistencyChecker.java

diff --git a/java/com/google/gerrit/server/change/ConsistencyChecker.java b/java/com/google/gerrit/server/change/ConsistencyChecker.java
index a379f2c..c7d23e8 100644
--- a/java/com/google/gerrit/server/change/ConsistencyChecker.java
+++ b/java/com/google/gerrit/server/change/ConsistencyChecker.java
@@ -52,7 +52,6 @@
 import com.google.gerrit.server.plugincontext.PluginItemContext;
 import com.google.gerrit.server.update.BatchUpdate;
 import com.google.gerrit.server.update.BatchUpdateOp;
-import com.google.gerrit.server.update.BatchUpdateReviewDb;
 import com.google.gerrit.server.update.ChangeContext;
 import com.google.gerrit.server.update.RepoContext;
 import com.google.gerrit.server.update.RetryHelper;
@@ -667,15 +666,9 @@
     public boolean updateChange(ChangeContext ctx)
         throws OrmException, PatchSetInfoNotAvailableException {
       // Delete dangling key references.
-      ReviewDb db = BatchUpdateReviewDb.unwrap(ctx.getDb());
       accountPatchReviewStore.run(s -> s.clearReviewed(psId), OrmException.class);
-      db.changeMessages().delete(db.changeMessages().byChange(psId.getParentKey()));
-      db.patchSetApprovals().delete(db.patchSetApprovals().byPatchSet(psId));
-      db.patchComments().delete(db.patchComments().byPatchSet(psId));
-      db.patchSets().deleteKeys(Collections.singleton(psId));
 
-      // NoteDb requires no additional fiddling; setting the state to deleted is
-      // sufficient to filter everything else out.
+      // For NoteDb setting the state to deleted is sufficient to filter everything out.
       ctx.getUpdate(psId).setPatchSetState(PatchSetState.DELETED);
 
       p.status = Status.FIXED;