| commit | 1c8af9bcf033ef870b0d522d572713097a126dca | [log] [tgz] |
|---|---|---|
| author | Kamil Musin <kamilm@google.com> | Mon Aug 21 16:50:01 2023 +0200 |
| committer | Luca Milanesio <luca.milanesio@gmail.com> | Wed Apr 10 19:37:19 2024 +0000 |
| tree | 2c1f21b977fb514e32984725a34a5528e0ff87c9 | |
| parent | 2c44778ab9aed093f1f63fb086f986c462d9dc50 [diff] |
Fix gr-dropdown-list not updating on items change handleValueChanged is dependent on contents of `items` therefore it needs to be recalculated if it changes. items were being received/set later than path when loading gr-diff-view from a url, resulting in no path shown in the gr-dropdown-list We only emit an event if the new value matches one of the items. It matches the behaviour before the change. It might make sense to emit the value anyway, but that broke gr-admin-view tests, because they don't set up rest api calls. So we keep it at the old behaviour. Also, spotted some small indexing errors in admin-view tests and fixed that. Google-Bug-Id: b/296106236 Release-Notes: skip Change-Id: I6b5457f71b573c9c56c425372cb0f4ec242e10f0 (cherry picked from commit ae6aa0f26a985d7ac34b3eef5be6ef24c1bbda86)
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.