commit 1ba850e5947176b7e2fee0407e22b1f87045aa86
author Kasper Nilsson <kaspern@google.com> Mon Nov 28 15:16:21 2016 -0800
committer Kasper Nilsson <kaspern@google.com> Fri Dec 02 15:25:27 2016 -0800
tree 00338f5c050a431161b8b49fba02269707656787
parent 23f975064c2d04ba9b87a55fd6ff5c94f5c7ee03

Fix comment copy logic

The addition of formatting in comments broke a variety of things having
to do with the copying logic. This change updates the logic and tests
to reflect the new DOM.

This issue arose because of a lack of integration tests for copying and
selection. That test is coming in a descendant change.

Bug: Issue 4969
Change-Id: I4e1994ab07947506c77b07877a46a9369d666d50

polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js

diff --git a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js
index 1d63b47..f8f646a 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js
+++ b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js
@@ -241,6 +241,7 @@
     _handleCKey: function(e) {
       if (this.shouldSuppressKeyboardShortcut(e)) { return; }
       if (this.$.diff.isRangeSelected()) { return; }
+      if (this.modifierPressed(e)) { return; }
 
       e.preventDefault();
       var line = this.$.cursor.getTargetLineElement();