| commit | 7872b543bb4545b1389fd019b002d3fd48619442 | [log] [tgz] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Tue Jul 12 13:22:10 2016 -0400 |
| committer | David Pursehouse <dpursehouse@collab.net> | Fri Jul 15 16:16:59 2016 +0900 |
| tree | ce1832de7e7e79de556873a6d610f6239d6ba394 | |
| parent | 597e1981160d9e4a4022b3f5fbf4d3da547b1cf6 [diff] |
PatchSetInserter: Always use db from Context This was missed in the original conversion of PatchSetInserter to a BatchUpdate.Op back in If267dcf1. Usually, the ReviewDb instance that is injected into a new PatchSetInserter is the same one that is used to create the BatchUpdate, so having two names for the same object is not a problem. However, while rewriting ConsistencyChecker for NoteDb, I came across a codepath where they are not the same. This has the unfortunate effect of trying to read from one database handle while there is an open transaction in another handle. In H2 this manifests as a timeout trying to lock the table. Change-Id: Ifc9c85e8515605970227578c6aa8f6d0b005ab73
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.