Fix closure error on `JSC_PRIMITIVE_OBJECT_DECLARATION`
when define type for primitives, should use `string` instead of `String`
Change-Id: I12d494c5256ec4dea99906190ad1229ca28d71c4
diff --git a/polygerrit-ui/app/behaviors/gr-patch-set-behavior/gr-patch-set-behavior.html b/polygerrit-ui/app/behaviors/gr-patch-set-behavior/gr-patch-set-behavior.html
index 84d6cab..7b7a1be 100644
--- a/polygerrit-ui/app/behaviors/gr-patch-set-behavior/gr-patch-set-behavior.html
+++ b/polygerrit-ui/app/behaviors/gr-patch-set-behavior/gr-patch-set-behavior.html
@@ -54,7 +54,7 @@
* number).
*
* @param {string|number} n
- * @return {Boolean}
+ * @return {boolean}
*/
isMergeParent(n) {
return (n + '')[0] === '-';
@@ -210,13 +210,13 @@
return allPatchSets[0].num;
},
- /** @return {Boolean} */
+ /** @return {boolean} */
hasEditBasedOnCurrentPatchSet(allPatchSets) {
if (!allPatchSets || allPatchSets.length < 2) { return false; }
return allPatchSets[0].num === Gerrit.PatchSetBehavior.EDIT_NAME;
},
- /** @return {Boolean} */
+ /** @return {boolean} */
hasEditPatchsetLoaded(patchRangeRecord) {
const patchRange = patchRangeRecord.base;
if (!patchRange) { return false; }
diff --git a/polygerrit-ui/app/behaviors/rest-client-behavior/rest-client-behavior.html b/polygerrit-ui/app/behaviors/rest-client-behavior/rest-client-behavior.html
index 2237866..709cc8a 100644
--- a/polygerrit-ui/app/behaviors/rest-client-behavior/rest-client-behavior.html
+++ b/polygerrit-ui/app/behaviors/rest-client-behavior/rest-client-behavior.html
@@ -169,7 +169,7 @@
/**
* @param {!Object} change
- * @return {String}
+ * @return {string}
*/
changeStatusString(change) {
return this.changeStatuses(change).join(', ');
diff --git a/polygerrit-ui/app/elements/admin/gr-plugin-config-array-editor/gr-plugin-config-array-editor.js b/polygerrit-ui/app/elements/admin/gr-plugin-config-array-editor/gr-plugin-config-array-editor.js
index 854bbbc..c0ad9d42 100644
--- a/polygerrit-ui/app/elements/admin/gr-plugin-config-array-editor/gr-plugin-config-array-editor.js
+++ b/polygerrit-ui/app/elements/admin/gr-plugin-config-array-editor/gr-plugin-config-array-editor.js
@@ -31,7 +31,7 @@
return {
/** @type {?} */
pluginOption: Object,
- /** @type {Boolean} */
+ /** @type {boolean} */
disabled: {
type: Boolean,
computed: '_computeDisabled(pluginOption.*)',
diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.js b/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.js
index 3d2c108..cdd3cdb 100644
--- a/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.js
+++ b/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.js
@@ -119,13 +119,13 @@
value: true,
},
- /** @type {?String} */
+ /** @type {?string} */
_userId: {
type: String,
value: null,
},
- /** @type {?String} */
+ /** @type {?string} */
_repo: {
type: String,
value: null,
diff --git a/polygerrit-ui/app/elements/change-list/gr-repo-header/gr-repo-header.js b/polygerrit-ui/app/elements/change-list/gr-repo-header/gr-repo-header.js
index c603c45..d4bd1df 100644
--- a/polygerrit-ui/app/elements/change-list/gr-repo-header/gr-repo-header.js
+++ b/polygerrit-ui/app/elements/change-list/gr-repo-header/gr-repo-header.js
@@ -24,12 +24,12 @@
static get properties() {
return {
- /** @type {?String} */
+ /** @type {?string} */
repo: {
type: String,
observer: '_repoChanged',
},
- /** @type {String|null} */
+ /** @type {string|null} */
_repoUrl: String,
};
}
diff --git a/polygerrit-ui/app/elements/change-list/gr-user-header/gr-user-header.js b/polygerrit-ui/app/elements/change-list/gr-user-header/gr-user-header.js
index d9e9107..40f0b73 100644
--- a/polygerrit-ui/app/elements/change-list/gr-user-header/gr-user-header.js
+++ b/polygerrit-ui/app/elements/change-list/gr-user-header/gr-user-header.js
@@ -24,7 +24,7 @@
static get properties() {
return {
- /** @type {?String} */
+ /** @type {?string} */
userId: {
type: String,
observer: '_accountChanged',
@@ -48,7 +48,7 @@
value: null,
},
- /** @type {?String} */
+ /** @type {?string} */
_status: {
type: String,
value: null,
diff --git a/polygerrit-ui/app/elements/plugins/gr-styles-api/gr-styles-api.js b/polygerrit-ui/app/elements/plugins/gr-styles-api/gr-styles-api.js
index 0a61062..9ea5c8a 100644
--- a/polygerrit-ui/app/elements/plugins/gr-styles-api/gr-styles-api.js
+++ b/polygerrit-ui/app/elements/plugins/gr-styles-api/gr-styles-api.js
@@ -71,7 +71,7 @@
/**
* Creates a new GrStyleObject with specified style properties.
*
- * @param {string} String with style properties.
+ * @param {string} ruleStr with style properties.
* @return {GrStyleObject}
*/
GrStylesApi.prototype.css = function(ruleStr) {
diff --git a/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-annotation-actions-js-api.js b/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-annotation-actions-js-api.js
index 7ff0ae4..4025cdc 100644
--- a/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-annotation-actions-js-api.js
+++ b/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-annotation-actions-js-api.js
@@ -101,7 +101,7 @@
* https://bugs.chromium.org/p/gerrit/issues/detail?id=8077 is
* implemented.
*
- * @param {String} checkboxLabel Will be used as the label for the checkbox.
+ * @param {string} checkboxLabel Will be used as the label for the checkbox.
* Optional. "Enable" is used if this is not specified.
* @param {function(HTMLElement)} onAttached The function that will be called
* when the checkbox is attached to the page.
@@ -133,10 +133,10 @@
* layers. Intended to be called by the plugin when all required data for
* annotation is available.
*
- * @param {String} path The file path whose listeners should be notified.
- * @param {Number} start The line where the update starts.
- * @param {Number} end The line where the update ends.
- * @param {String} side The side of the update ('left' or 'right').
+ * @param {string} path The file path whose listeners should be notified.
+ * @param {number} start The line where the update starts.
+ * @param {number} end The line where the update ends.
+ * @param {string} side The side of the update ('left' or 'right').
*/
GrAnnotationActionsInterface.prototype.notify = function(
path, startRange, endRange, side) {
@@ -154,9 +154,9 @@
* Should be called to register annotation layers by the framework. Not
* intended to be called by plugins.
*
- * @param {String} path The file path (eg: /COMMIT_MSG').
- * @param {String} changeNum The Gerrit change number.
- * @param {String} patchNum The Gerrit patch number.
+ * @param {string} path The file path (eg: /COMMIT_MSG').
+ * @param {string} changeNum The Gerrit change number.
+ * @param {string} patchNum The Gerrit patch number.
*/
GrAnnotationActionsInterface.prototype.getLayer = function(
path, changeNum, patchNum) {
@@ -170,9 +170,9 @@
* Used to create an instance of the Annotation Layer interface.
*
* @constructor
- * @param {String} path The file path (eg: /COMMIT_MSG').
- * @param {String} changeNum The Gerrit change number.
- * @param {String} patchNum The Gerrit patch number.
+ * @param {string} path The file path (eg: /COMMIT_MSG').
+ * @param {string} changeNum The Gerrit change number.
+ * @param {string} patchNum The Gerrit patch number.
* @param {function(GrAnnotationActionsContext)} addLayerFunc The function
* that will be called when the AnnotationLayer is ready to annotate.
*/
@@ -188,7 +188,7 @@
/**
* Register a listener for layer updates.
*
- * @param {function(Number, Number, String)} fn The update handler function.
+ * @param {Function} fn The update handler function.
* Should accept as arguments the line numbers for the start and end of
* the update and the side as a string.
*/
@@ -215,9 +215,9 @@
/**
* Notify Layer listeners of changes to annotations.
*
- * @param {Number} start The line where the update starts.
- * @param {Number} end The line where the update ends.
- * @param {String} side The side of the update. ('left' or 'right')
+ * @param {number} start The line where the update starts.
+ * @param {number} end The line where the update ends.
+ * @param {string} side The side of the update. ('left' or 'right')
*/
AnnotationLayer.prototype.notifyListeners = function(
startRange, endRange, side) {
diff --git a/polygerrit-ui/app/elements/shared/gr-label-info/gr-label-info.js b/polygerrit-ui/app/elements/shared/gr-label-info/gr-label-info.js
index 0e529b1..590d753 100644
--- a/polygerrit-ui/app/elements/shared/gr-label-info/gr-label-info.js
+++ b/polygerrit-ui/app/elements/shared/gr-label-info/gr-label-info.js
@@ -98,7 +98,7 @@
*
* @param {!Object} reviewer An object describing the reviewer that left the
* vote.
- * @param {Boolean} mutable
+ * @param {boolean} mutable
* @param {!Object} change
*/
_computeDeleteClass(reviewer, mutable, change) {
diff --git a/polygerrit-ui/app/elements/shared/gr-textarea/gr-textarea.js b/polygerrit-ui/app/elements/shared/gr-textarea/gr-textarea.js
index 5b17a38..0c237bc 100644
--- a/polygerrit-ui/app/elements/shared/gr-textarea/gr-textarea.js
+++ b/polygerrit-ui/app/elements/shared/gr-textarea/gr-textarea.js
@@ -94,7 +94,7 @@
type: Boolean,
value: false,
},
- /** @type(?number) */
+ /** @type {?number} */
_colonIndex: Number,
_currentSearchString: {
type: String,
diff --git a/polygerrit-ui/app/elements/shared/revision-info/revision-info.html b/polygerrit-ui/app/elements/shared/revision-info/revision-info.html
index b845c09..239e0fa 100644
--- a/polygerrit-ui/app/elements/shared/revision-info/revision-info.html
+++ b/polygerrit-ui/app/elements/shared/revision-info/revision-info.html
@@ -34,7 +34,7 @@
* wherein the revisions are merge commits this will return 2 or potentially
* more.
*
- * @return {Number}
+ * @return {number}
*/
RevisionInfo.prototype.getMaxParents = function() {
if (!this._change || !this._change.revisions) {
