| commit | 1ac97005e3dbeaef4e4b70a5267c00f71893f606 | [log] [tgz] |
|---|---|---|
| author | Youssef Elghareeb <ghareeb@google.com> | Tue Nov 09 14:24:22 2021 +0100 |
| committer | Youssef Elghareeb <ghareeb@google.com> | Wed Nov 10 10:56:39 2021 +0100 |
| tree | 465c76df4427959c3dc90e4ec41baa901964f136 | |
| parent | 6e4fb958b5bd7f2d52a080ca3eaef365587b3e3d [diff] |
Submit requirements: Add a custom serializer for ObjectId
Submit requirement results are serialized and stored as Json in NoteDb
when the change is merged. We use a custom Gson serializer (defined in
ChangeNoteJson) that registers adapters to different objects. We have
not previously registered an adapter for the ObjectId class, resulting
in serializing the ObjectId using the JGit format {w1, w2, w3, w4, w5}.
In this change, we implement a custom adapter for ObjectId and ensure
that the "deserialize" method can parse both the JGit and the new format
to preserve backward compatibility.
I also added tests to ensure proper serialization for all submit
requirement entities: SubmitRequirement, SubmitRequirementExpression,
SubmitRequirementResult and SubmitRequirementExpressionResult.
Bug: Google b/202927636
Change-Id: I91d0ceaf8dd0b1c4d5b0245ac97258e1a956fc8e
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.