| commit | 195f9549ad1aa86d8d5c6c5952e869647c866d60 | [log] [tgz] |
|---|---|---|
| author | Chris Poucet <poucet@google.com> | Wed Jun 01 10:03:12 2022 +0200 |
| committer | Chris Poucet <poucet@google.com> | Tue Jun 07 13:48:48 2022 +0200 |
| tree | f43f1588e117e42796baa467011182025c714e6c | |
| parent | 4c83d31c571c5a52ed5cd660a6d1650cb285f159 [diff] |
Rerender a diff if it's reconnected and avoid reusing GrDiffCursor. This is fixing three bugs: 1. When navigating back and forth between the change page and first diff, on the second navigation commenting no longer works. This is because 'render-content' is never thrown because gr-diff doesn't actually re-render. 2. By reusing GrDiffCursor across multiple connectedCallbacks, we are not undoing what GrDiffCursor.dispose does which is called from the disconnectedCallback. An alternative solution here would be to introduce a GrDiffCursor.setup. The reason this was not chosen is that with the fix to #1, we're always calling reInitCursor on the GrDiffCursor so reusing it does not benefit from any runtime wins. The reason we're always calling it is that with fix #1, we always re-render when reopening the same diff. 3. A similar issue to #1 was happening on the change page. The diff-cursor was no longer working when navigating to the change-page. This was due to re-use of the GrDiffCursor in gr-file-list. Google-Bug-Id: b/189046319, b/234810452 Release-Notes: skip Change-Id: I512ac179f29954e2ca29f68f335446104194b85e
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.