| commit | f130fc84e1f4fa62d9fa61dd3cb0c1d33f847052 | [log] [tgz] |
|---|---|---|
| author | Youssef Elghareeb <ghareeb@google.com> | Thu Oct 28 16:49:08 2021 +0200 |
| committer | Youssef Elghareeb <ghareeb@google.com> | Thu Oct 28 16:49:08 2021 +0200 |
| tree | 9a252b130cb268cc25c192365bf76ba42e6d9889 | |
| parent | 56944f825d89211c264de45a0a83bd54eabcd9c7 [diff] |
Refactor LabelsJson#permittedLabels We want to reduce the number of callers that rely on submit records. LabelsJson#permittedLabels is one such case. Currently, this method returns the range of permissible votes for different labels for a specific user. It retrieves submit records with the "LENIENT" option to retrieve the label names, checks if each label is a valid label name (since submit records can return virtual labels) and does checks for each vote value to determine if the user has permission to vote. The "LENIENT" always recomputes submit records, even if the change is closed. This means that all involved submit rules will evaluate the rules and labels for the current project state. For this reason it makes sense to just iterate on the available current labels directly instead of invoking submit records. The only effect this has is that submit rules can omit some labels, for example Prolog can skip some labels under certain conditions. This should be fine since we are anyway intending to separate labels from submit requirements (or submit rules previously). The frontend should decide if we should display all range of permissible votes or not. Change-Id: Id9b653f6be3c6572c085c6098f404ab4025cc41f
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.