Google Git
Sign in
gerrit / gerrit / 18ded36feb079f54c0eb43e06cec06f19a690bdf
commit18ded36feb079f54c0eb43e06cec06f19a690bdf[log] [tgz]
authorKasper Nilsson <kaspern@google.com>Wed Sep 19 14:03:39 2018 -0700
committerKasper Nilsson <kaspern@google.com>Wed Sep 19 14:08:46 2018 -0700
tree31fc2cd54a8190dce21ba14fc3e9c45181348029
parenta5fe3c44d755b97b1c880575ce2ecc5b873cb74b [diff]
Fix Gerrit global scoping issue

I47a487e3 added the definition of the Gerrit global to help enable
Closure compilation. However, the object created by
`let Gerrit = window.Gerrit || {}` was never reassigned to
window.Gerrit, leading to window.Gerrit being initialized to a different
empty object when the first behavior was loaded.

A gr-endpoint-decorator element is included in gr-app.html. For that
specific endpoint, the Gerrit object referenced in
gr-endpoint-decorator.js was not the window.Gerrit object that contained
the properly initialized endpoints.

With this change, the object reference is reassigned window.Gerrit in
every root view touched by the aforementioned change.

Change-Id: I0d571918043311ac07a966d0faf126d355b55a5b
3 files changed
tree: 31fc2cd54a8190dce21ba14fc3e9c45181348029
  1. .settings/
  2. antlr3/
  3. contrib/
  4. Documentation/
  5. gerrit-gwtdebug/
  6. gerrit-gwtui/
  7. gerrit-gwtui-common/
  8. gerrit-plugin-gwtui/
  9. java/
  10. javatests/
  11. lib/
  12. plugins/
  13. polygerrit-ui/
  14. prolog/
  15. prologtests/
  16. proto/
  17. resources/
  18. tools/
  19. webapp/
  20. .bazelproject
  21. .bazelrc
  22. .editorconfig
  23. .git-blame-ignore-revs
  24. .gitignore
  25. .gitmodules
  26. .mailmap
  27. .pydevproject
  28. BUILD
  29. COPYING
  30. INSTALL
  31. README.md
  32. SUBMITTING_PATCHES
  33. version.bzl
  34. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.