commit | 1851a8b7860b15ed63e05f8d72ecdb7efac32b3f | [log] [tgz] |
---|---|---|
author | Patrick Hiesel <hiesel@google.com> | Fri Aug 25 15:55:26 2017 +0200 |
committer | Patrick Hiesel <hiesel@google.com> | Tue Oct 10 11:34:45 2017 +0000 |
tree | 055e696a3fe22460da7be4435297c7edf64f4c20 | |
parent | e3762b84ece7c8eaf25fd9f4b766c06dd60c50ed [diff] |
Make RefControl package-private This commit makes RefControl package-private by removing all references by migrating all callers to PermissionBackend. It makes the following non-trivial changes: 1) Decompose ref-ownership into READ_CONFIG and WRITE_CONFIG. WRITE_CONFIG serves as the traditional isOwner() while READ_CONFIG can be used to check if the user can read the ref config. This defaults to READ on refs/meta/config for now but can be more specific in the future. 2) Add a new READ_PRIVATE_CHANGES permission to RefPermission to account for canReadPrivateChanges() and isEditVisible(). This is used for VisibleRefsFilter. This commit leaves a TODO for the future on how to treat ref owners in emails. As of now, we still upgrade owners to 'TO' when they are on either 'CC' or 'BCC'. This will change in a follow-up change as it is hard to support on top of a permission backend as it involves many permission checks on every email sent as well as confusing as internally we don't have a ref owner anymore. Change-Id: Ia6fa468dac49588241b52b4451fe79bcf6776077
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.