| commit | 17f3325b5e44220b5707874dac3ca537402e85d9 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Mon Jan 20 09:48:15 2020 +0100 |
| committer | Edwin Kempin <ekempin@google.com> | Mon Jan 20 09:21:27 2020 +0000 |
| tree | 927a4334527bae118b4b7141bfe3b3856d2f6e7c | |
| parent | b07d40a32edf5dcd0cef5e592861e86c8bb514e7 [diff] |
RestApiServlet: Include formatted cause into log on internal server error If there is an exception that is caused by a temporary error RetryHelper takes care to retry the request for a short time. Most of the time this makes the request be successful, however sometimes the temporary error persists for the time of the retry, in which case RetryHelper will throw the exception and RestApiServlet will log it and return '500 Internal Server Error'. When looking at the logs of internal server errors one cannot see if the exception had triggering retries and timed out or if it was thrown without retries. This distinction is important if you investigate internal server errors. If there is an internal server error that is caused by a temporary issue, you wonder if retrying for it should be added or if retrying was already in place but didn't help. This information can be made available in the logs by including the formatted cause, since all exceptions which trigger retries have defined a distinguishable formatted cause. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: Iac345839b8fc4791b58aeaa4a0b785bb8c2e7b31
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.