ES6ify /gr-change-list-item/*
Bug: Issue 6179
Change-Id: I6b45fbd503409d2019ea624d258891e670e11bc3
diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.js b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.js
index 566dfe0..1616e1f 100644
--- a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.js
+++ b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.js
@@ -40,15 +40,15 @@
Gerrit.URLEncodingBehavior,
],
- _computeChangeURL: function(changeNum) {
+ _computeChangeURL(changeNum) {
if (!changeNum) { return ''; }
return this.getBaseUrl() + '/c/' + changeNum + '/';
},
- _computeLabelTitle: function(change, labelName) {
- var label = change.labels[labelName];
+ _computeLabelTitle(change, labelName) {
+ const label = change.labels[labelName];
if (!label) { return 'Label not applicable'; }
- var significantLabel = label.rejected || label.approved ||
+ const significantLabel = label.rejected || label.approved ||
label.disliked || label.recommended;
if (significantLabel && significantLabel.name) {
return labelName + '\nby ' + significantLabel.name;
@@ -56,12 +56,12 @@
return labelName;
},
- _computeLabelClass: function(change, labelName) {
- var label = change.labels[labelName];
+ _computeLabelClass(change, labelName) {
+ const label = change.labels[labelName];
// Mimic a Set.
- var classes = {
- 'cell': true,
- 'label': true,
+ const classes = {
+ cell: true,
+ label: true,
};
if (label) {
if (label.approved) {
@@ -83,8 +83,8 @@
return Object.keys(classes).sort().join(' ');
},
- _computeLabelValue: function(change, labelName) {
- var label = change.labels[labelName];
+ _computeLabelValue(change, labelName) {
+ const label = change.labels[labelName];
if (!label) { return ''; }
if (label.approved) {
return '✓';
@@ -101,12 +101,12 @@
return '';
},
- _computeProjectURL: function(project) {
+ _computeProjectURL(project) {
return this.getBaseUrl() + '/q/status:open+project:' +
this.encodeURL(project, false);
},
- _computeProjectBranchURL: function(project, branch) {
+ _computeProjectBranchURL(project, branch) {
// @see Issue 4255.
return this._computeProjectURL(project) +
'+branch:' + this.encodeURL(branch, false);
diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.html b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.html
index ad76f10..ce7084b 100644
--- a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.html
+++ b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.html
@@ -34,19 +34,19 @@
</test-fixture>
<script>
- suite('gr-change-list-item tests', function() {
- var element;
+ suite('gr-change-list-item tests', () => {
+ let element;
- setup(function() {
+ setup(() => {
stub('gr-rest-api-interface', {
- getConfig: function() { return Promise.resolve({}); },
- getLoggedIn: function() { return Promise.resolve(false); },
+ getConfig() { return Promise.resolve({}); },
+ getLoggedIn() { return Promise.resolve(false); },
});
element = fixture('basic');
});
- test('change status', function() {
- var getStatusForChange = function(change) {
+ test('change status', () => {
+ const getStatusForChange = function(change) {
element.change = change;
return element.$$('.cell.status').textContent.trim();
};
@@ -59,7 +59,7 @@
assert.equal(getStatusForChange({status: 'DRAFT'}), 'Draft');
});
- test('computed fields', function() {
+ test('computed fields', () => {
assert.equal(element._computeLabelClass({labels: {}}),
'cell label u-gray-background');
assert.equal(element._computeLabelClass(
@@ -99,19 +99,19 @@
'Code-Review'), 'Code-Review\nby Diffy');
assert.equal(element._computeLabelTitle(
{labels: {'Code-Review': {recommended: {name: 'Diffy'},
- rejected: {name: 'Admin'}}}}, 'Code-Review'),
+ rejected: {name: 'Admin'}}}}, 'Code-Review'),
'Code-Review\nby Admin');
assert.equal(element._computeLabelTitle(
{labels: {'Code-Review': {approved: {name: 'Diffy'},
- rejected: {name: 'Admin'}}}}, 'Code-Review'),
+ rejected: {name: 'Admin'}}}}, 'Code-Review'),
'Code-Review\nby Admin');
assert.equal(element._computeLabelTitle(
{labels: {'Code-Review': {recommended: {name: 'Diffy'},
- disliked: {name: 'Admin'}, value: -1}}}, 'Code-Review'),
+ disliked: {name: 'Admin'}, value: -1}}}, 'Code-Review'),
'Code-Review\nby Admin');
assert.equal(element._computeLabelTitle(
{labels: {'Code-Review': {approved: {name: 'Diffy'},
- disliked: {name: 'Admin'}, value: -1}}}, 'Code-Review'),
+ disliked: {name: 'Admin'}, value: -1}}}, 'Code-Review'),
'Code-Review\nby Diffy');
assert.equal(element._computeLabelValue({labels: {}}), '');
@@ -140,7 +140,7 @@
assert.equal(element.changeURL, '/c/43/');
});
- test('no hidden columns', function() {
+ test('no hidden columns', () => {
element.visibleChangeTableColumns = [
'Subject',
'Status',
@@ -153,13 +153,13 @@
flushAsynchronousOperations();
- element.columnNames.forEach(function(column) {
- var elementClass = '.' + column.toLowerCase();
+ for (const column of element.columnNames) {
+ const elementClass = '.' + column.toLowerCase();
assert.isFalse(element.$$(elementClass).hidden);
- });
+ }
});
- test('no hidden columns', function() {
+ test('no hidden columns', () => {
element.visibleChangeTableColumns = [
'Subject',
'Status',
@@ -172,13 +172,13 @@
flushAsynchronousOperations();
- element.columnNames.forEach(function(column) {
- var elementClass = '.' + column.toLowerCase();
+ for (const column of element.columnNames) {
+ const elementClass = '.' + column.toLowerCase();
assert.isFalse(element.$$(elementClass).hidden);
- });
+ }
});
- test('project column hidden', function() {
+ test('project column hidden', () => {
element.visibleChangeTableColumns = [
'Subject',
'Status',
@@ -190,25 +190,24 @@
flushAsynchronousOperations();
- element.columnNames.forEach(function(column) {
- var elementClass = '.' + column.toLowerCase();
+ for (const column of element.columnNames) {
+ const elementClass = '.' + column.toLowerCase();
if (column === 'Project') {
assert.isTrue(element.$$(elementClass).hidden);
} else {
assert.isFalse(element.$$(elementClass).hidden);
}
- });
+ }
});
- test('random column does not exist', function() {
+ test('random column does not exist', () => {
element.visibleChangeTableColumns = [
'Bad',
];
flushAsynchronousOperations();
- var elementClass = '.bad';
+ const elementClass = '.bad';
assert.isNotOk(element.$$(elementClass));
});
-
- });
+});
</script>
