| commit | 165d5d33b5e64cb36ec0bb6a031c14554897d841 | [log] [tgz] |
|---|---|---|
| author | Wyatt Allen <wyatta@google.com> | Tue Jun 07 16:23:29 2016 -0700 |
| committer | Wyatt Allen <wyatta@google.com> | Tue Jun 07 16:53:59 2016 -0700 |
| tree | 4486901301f753f17a0f705eaf049c21129aa605 | |
| parent | a4bfc04bc018bf469fe787ee0a3473c4bc3cc52a [diff] |
Restores a11y tabbing behavior to gr-reply-dialog The iron-overlay-behavior tries to prevent the user from tabbing outside of the overlay by recording the first and last child elements which appear to be focusable. It intercepts [Tab] and [Shift+Tab] keystrokes to wrap the tab-order of its controls. However, the way it determines the first and last such element is 1) not composable with child elements that are Polymer components and 2) not composable with dynamically changing children. Because gr-reply-dialog is both 1) built with Polymer components and 2) partially dynamically generated, the tab order is broken when the overlay behavior tries to intercept and constrain it. The workaround here is to remove the iron-overlay-behavior's guesswork and manually set the first and last focusable inputs with knowledge of what those elements would be in gr-reply-dialog. gr-overlay's #open method now returns a promise that resolves when the overlay is actually displayed. Bug: Issue 4165 Change-Id: Ib1cdea4c5e99f821db699c89743240caab751f03
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.