| commit | befd41e506fd24f58f400dbb28566c98349d59da | [log] [tgz] |
|---|---|---|
| author | Kamil Musin <kamilm@google.com> | Tue Aug 22 12:36:37 2023 +0200 |
| committer | Luca Milanesio <luca.milanesio@gmail.com> | Wed Apr 10 19:37:57 2024 +0000 |
| tree | 83e8c0345d98fe405d661012fc9ead71d6431034 | |
| parent | 1c8af9bcf033ef870b0d522d572713097a126dca [diff] |
Emit value change event even when no items are matched In I6b5457f71 we kept the original logic, where the event is only emitted if value changed and one of the items matched. But that creates an issue if value and items are updated on separate iterations. 1. Value updates, no items -> so no event 2. Items update, no value change -> so no event Even though in the end both value and items satisfy the requirement, the event was never sent. Since gr-dropdown-list is a utility class it generally makes sense for it to be as simple as possible, and not try to account for logic of components using it. The issue in gr-admin-view that didn't work with this previously was that it doesn't maintain it's own invariants: It was possible for the value set on gr-dropdown-list to not be in the subsectionLinks, due to render happening in the middle of `reload()`. We fix this issue in this change. Release-Notes: skip Google-Bug-Id: b/296106236 Change-Id: I9dfe61d6f7a247842e5392976378915eec6775f2 (cherry picked from commit 13948dfbb562033992d5b5346970de755a2a574a)
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.