| commit | 15615078df91a5c8c9624467bf1542c9b6f13f06 | [log] [tgz] |
|---|---|---|
| author | Changcheng Xiao <xchangcheng@google.com> | Thu Feb 16 13:48:30 2017 +0100 |
| committer | Changcheng Xiao <xchangcheng@google.com> | Fri Feb 17 07:57:03 2017 +0000 |
| tree | 2cd326cd448298565748a7ba97ae555d52baa3ef | |
| parent | 3ae681fd6e39a7709a319eefb8d5e87e98b5dfcf [diff] |
Fix GWT UI AddFileBox to provide path suggestions continuously - How to reproduce the bug? In ChangeScreen, click 'Edit', then 'Add...'. Type in some text, you will get some path suggestions. Delete all the text you've typed in. There will be no suggestion any more until the page is reloaded. - Why does this happen? The UI will continue create new query when the text box is focused and the 'query' is null in RemoteSuggestOracle. When the text box is cleared, it will result in a NullPointerException in RESTApi.addParameter(String, String) when it calls URL.encodeQueryString as the request.getQuery() is null. Once this exception happens, onSuggestionReady will not be called and 'query' field in RemoteSuggestOracle will not be reset to null. That's why the UI will not try new Request until the page is reloaded. This problem may be related to GWT 2.8 upgrade. It started behaving differently after the upgrade. However, I haven't noticed this problem for reviewers suggestion. - Solution Set the query to be empty when request.getQuery() is null. Bug: Issue 5365 Change-Id: Ia0878b67aebde854012e3cacec51d922a9f32919
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.