commit | 14e1ad52d6b123856bd5a47ba96cd247da9d8164 | [log] [tgz] |
---|---|---|
author | Dave Borowitz <dborowitz@google.com> | Mon Nov 19 12:33:56 2018 -0800 |
committer | Dave Borowitz <dborowitz@google.com> | Tue Nov 20 12:27:40 2018 -0800 |
tree | 9218f33af35202976f6d9478afe319bd73496fee | |
parent | ce3f18015fc0a2268fe186165d7e44ed7b098f70 [diff] |
Make most small tests inherit from GerritBaseTests One of the main purposes of GerritBaseTests is a place to park the KeyUtil#setEncoderImpl call, which avoids NPEs when calling any gwtorm Key#toString method. Many tests pass today without this base class for one of a few reasons: * They never call Key#toString, or perhaps only call it lazily on test failures. * They transitively load some other class which has setEncoderImpl in its static block, such as Database. * They are run with `bazel test` in the same JVM/classloader as another test class which does inherit GerritBaseTests or otherwise indirectly calls setEncoderImpl. (If any tests exist in this category, then they already fail if run singly in an IDE or with a restricted --test_filter.) In order to avoid having to reason about whether a particular test does or does not depend on setEncoderImpl, just use GerritBaseTests consistently. This will prevent spurious test failures when we start removing classes like Database as we cut out ReviewDb. This change modifies all classes named *Test.java which were not previously inheriting from any base class. Remaining tests will be fixed in followups. Change-Id: I32f5456d2ebc5e545cc89ad65f74139bd3506aaa
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.