Account for 'value' when parsing votable labels
In addition to permitted_voting_range, user may vote on a label if the
label has 'value' property.
Bug: b/77913572
Change-Id: I0db60a8e1dbf92c83e443c600f8b1e6c0fcbbf94
diff --git a/polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list.js b/polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list.js
index aa3ddea..ab1f55e 100644
--- a/polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list.js
+++ b/polygerrit-ui/app/elements/change/gr-reviewer-list/gr-reviewer-list.js
@@ -126,10 +126,16 @@
if (!change.labels[label].all) { return NaN; }
const detailed = change.labels[label].all.filter(
({_account_id}) => reviewer._account_id === _account_id).pop();
- if (!detailed || !detailed.hasOwnProperty('permitted_voting_range')) {
+ if (!detailed) {
return NaN;
}
- return detailed.permitted_voting_range.max;
+ if (detailed.hasOwnProperty('permitted_voting_range')) {
+ return detailed.permitted_voting_range.max;
+ } else if (detailed.hasOwnProperty('value')) {
+ // If preset, user can vote on the label.
+ return 0;
+ }
+ return NaN;
},
_computeReviewerTooltip(reviewer, change) {
