commit | c07c18a68752aeba528cff6f33a9b87417c1b318 | [log] [tgz] |
---|---|---|
author | Edwin Kempin <ekempin@google.com> | Wed Feb 15 11:10:59 2017 +0100 |
committer | Edwin Kempin <ekempin@google.com> | Tue Mar 28 09:10:34 2017 +0200 |
tree | 9f9b2915bee9ad94433667e9bcf4d119f3503588 | |
parent | 6cbae560fa9c7677f615601184a5bdc0db4fda2f [diff] |
Migrate external IDs to NoteDb (part 2) This is the second part of migrating external IDs from ReviewDb to NoteDb. This change: * migrates the external IDs from ReviewDb to NoteDb (for single instance Gerrit servers) * adds a configuration parameter (user.readExternalIdsFromGit) that controls whether external IDs are read from ReviewDb or NoteDb The new ExternalIds class provides access to external IDs. All code that needs external IDs is adapted to use this class to retrieve external IDs (instead of reading directly from the database). ExternalIds gets the external IDs either directly from the storage backend (via ExternalIdReader) or from a cache (via ExternalIdCache). ExternalIdReader reads the external IDs from the storage backend. Depending on the value of the user.readExternalIdsFromGit parameter the external IDs are read from ReviewDB or NoteDb. If reading external IDs from NoteDb is enabled, reading the external IDs of an account requires parsing all Git notes. This is because external IDs are keyed by external ID key ('<scheme>:<id>') and the account ID is only contained in the Git note content. Since parsing all Git notes is too expensive if it is done frequently, there is a new external ID cache which makes external IDs accessible by account. This cache is populated once by reading all external IDs from NoteDb and is then kept up to date by informing it whenever an external ID is added, updated or deleted. The external ID cache uses the revision of the refs/meta/external-ids branch as key, so that all external IDs are reloaded when the refs/meta/external-ids branch is changed behind Gerrit's back. This makes it easy to use this cache in a multimaster setup, since an update of the refs/meta/external-ids branch which is done due to replication between nodes causes a reload of the external IDs in the receiving node. The ExternalIdCache is an implementation detail of how external IDs are read and written, which is why it is package private. Callers should always use ExternalIds to access external IDs and ExternalIdsUpdate / ExternalIdsBatchUpdate to update external IDs. The LocalUsernamesToLowerCase program needs to access all external IDs only once to update them. After the update they are not accessed again. Hence the LocalUsernamesToLowerCase program doesn't benefit from caching external IDs and the external ID cache can be disabled for it. The external ID cache is defined by the ExternalIdCache interface. It is implemented by ExternalIdCacheImpl and DisabledExternalIdCache. DisabledExternalIdCache can be used when an external ID cache is not needed, e.g. in the LocalUsernamesToLowerCase program or in tests. Pushing to the refs/meta/external-ids branch, which would only update the external IDs in NoteDb, is still prevented by a commit validator so that the external IDs in ReviewDb and NoteDb do not go out of sync. Change-Id: Ia1dae9306b7ee07388b6c5e1f3dc4a1a5eea4b08 Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.