commit 1347c2df7854e8b10248b0d69201d201fe95d164
author Dhruv <dhruvsri@google.com> Tue Jun 07 13:05:46 2022 +0200
committer Dhruv <dhruvsri@google.com> Tue Jun 07 16:26:17 2022 +0200
tree 1507edd2fc59411ef0a605e9a5d7b376d55f1f0a
parent d2fc1dbcc3e55a30b42b18f29553e8e3cb7eddac

Remove ChangeListView state

Change 338495 added caching for the change list view page.

Most of the optional properties defined in ChangeListViewState are
unused except offset and query which are used to fire a changed event
that is updating the changeListView state but isn't used afterwards.

Release-Notes: skip
Change-Id: I8b01662fc20cbc4eff8246952682461cb1f78a66

polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.ts

diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.ts b/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.ts
index ca76312..3bb7d8d 100644
--- a/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.ts
+++ b/polygerrit-ui/app/elements/change-list/gr-change-list-view/gr-change-list-view.ts
@@ -19,15 +19,13 @@
   RepoName,
 } from '../../../types/common';
 import {ChangeStarToggleStarDetail} from '../../shared/gr-change-star/gr-change-star';
-import {ChangeListViewState} from '../../../types/types';
-import {fire, fireTitleChange} from '../../../utils/event-util';
+import {fireTitleChange} from '../../../utils/event-util';
 import {getAppContext} from '../../../services/app-context';
 import {GerritView} from '../../../services/router/router-model';
 import {RELOAD_DASHBOARD_INTERVAL_MS} from '../../../constants/constants';
 import {sharedStyles} from '../../../styles/shared-styles';
 import {LitElement, PropertyValues, html, css} from 'lit';
 import {customElement, property, state, query} from 'lit/decorators';
-import {ValueChangedEvent} from '../../../types/events';
 
 const LOOKUP_QUERY_PATTERNS: RegExp[] = [
   /^\s*i?[0-9a-f]{7,40}\s*$/i, // CHANGE_ID
@@ -61,9 +59,6 @@
   account: AccountDetailInfo | null = null;
 
   @property({type: Object})
-  viewState: ChangeListViewState = {};
-
-  @property({type: Object})
   preferences?: PreferencesInput;
 
   // private but used in test
@@ -277,21 +272,11 @@
   private paramsChanged() {
     const value = this.params;
     if (!value || value.view !== GerritView.SEARCH) return;
+    const offset = isNaN(Number(value.offset)) ? 0 : Number(value.offset);
 
     this.loading = true;
     this.query = value.query;
-    const offset = Number(value.offset);
-    this.offset = isNaN(offset) ? 0 : offset;
-    if (
-      this.viewState.query !== this.query ||
-      this.viewState.offset !== this.offset
-    ) {
-      this.viewState.query = this.query;
-      this.viewState.offset = this.offset;
-      fire(this, 'view-state-change-list-view-changed', {
-        value: this.viewState,
-      });
-    }
+    this.offset = offset;
 
     // NOTE: This method may be called before attachment. Fire title-change
     // in an async so that attachment to the DOM can take place first.
@@ -414,9 +399,6 @@
 }
 
 declare global {
-  interface HTMLElementEventMap {
-    'view-state-change-list-view-changed': ValueChangedEvent<ChangeListViewState>;
-  }
   interface HTMLElementTagNameMap {
     'gr-change-list-view': GrChangeListView;
   }