Google Git
Sign in
gerrit / gerrit / 418c240713016adf039440f6ab5f7f45fea0163d
commit418c240713016adf039440f6ab5f7f45fea0163d[log] [tgz]
authorEdwin Kempin <ekempin@google.com>Mon Jan 22 08:38:45 2018 +0100
committerEdwin Kempin <ekempin@google.com>Mon Jan 22 08:48:05 2018 +0100
treece250b208a2fa3f0bfffc808ad37a699f28c472d
parentfc6ec5a31604f17a59508877ac7b8b65c854583a [diff]
Fix running git-upload-archive command for Gerrit slaves

Running the git-upload-archive command against Gerrit slaves fails with
a NullPointerException because it tries to access the change index which
is not available on Gerrit slaves.

Querying for visible changes to check if a commit is readable is an
optimization that was added by commit 50c8b63f67 [2] (the corresponding
change seems to be missing in the change index and hence I can't find
it).

Since querying for visible changes is an optimization only we can simply
skip it on slaves where a change index is not available and fall back
to checking the visibility of refs from which the commit is reachable.

[1]
[2018-01-22 13:16:45,059] [SSH git-upload-archive '/platform/packages/apps/Browser2' (xxx)] ERROR com.google.gerrit.sshd.BaseCommand : Internal server error (userxxx account 1000002) during git-upload-archive '/platform/packages/apps/Browser2'
java.lang.NullPointerException
        at com.google.gerrit.server.index.change.ChangeIndexRewriter.isIndexPredicate(ChangeIndexRewriter.java:245)
        at com.google.gerrit.server.index.change.ChangeIndexRewriter.rewriteImpl(ChangeIndexRewriter.java:183)
        at com.google.gerrit.server.index.change.ChangeIndexRewriter.rewriteImpl(ChangeIndexRewriter.java:208)
        at com.google.gerrit.server.index.change.ChangeIndexRewriter.rewriteImpl(ChangeIndexRewriter.java:156)
        at com.google.gerrit.server.index.change.ChangeIndexRewriter.rewrite(ChangeIndexRewriter.java:140)
        at com.google.gerrit.index.query.QueryProcessor.query(QueryProcessor.java:224)
        at com.google.gerrit.index.query.QueryProcessor.query(QueryProcessor.java:174)
        at com.google.gerrit.index.query.QueryProcessor.query(QueryProcessor.java:157)
        at com.google.gerrit.index.query.InternalQuery.query(InternalQuery.java:74)
        at com.google.gerrit.server.query.change.InternalChangeQuery.byProjectCommit(InternalChangeQuery.java:250)
        at com.google.gerrit.server.query.change.InternalChangeQuery.byProjectCommit(InternalChangeQuery.java:245)
        at com.google.gerrit.server.project.CommitsCollection.canRead(CommitsCollection.java:109)
        at com.google.gerrit.sshd.commands.UploadArchive.canRead(UploadArchive.java:253)
        at com.google.gerrit.sshd.commands.UploadArchive.runImpl(UploadArchive.java:188)
        at com.google.gerrit.sshd.AbstractGitCommand.service(AbstractGitCommand.java:102)
        at com.google.gerrit.sshd.AbstractGitCommand.access$000(AbstractGitCommand.java:32)
        at com.google.gerrit.sshd.AbstractGitCommand$1.run(AbstractGitCommand.java:67)
        at com.google.gerrit.sshd.BaseCommand$TaskThunk.run(BaseCommand.java:427)
        ...

[2] https://gerrit.googlesource.com/gerrit/+/50c8b63f6721d8aba6074b238664f3eee7a2dc64%5E%21/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectControl.java

Change-Id: Ic27ee3ccc5c9887a6a460c89fa29cb128b4c7af4
Signed-off-by: Edwin Kempin <ekempin@google.com>
1 file changed
tree: ce250b208a2fa3f0bfffc808ad37a699f28c472d
  1. .settings/
  2. contrib/
  3. Documentation/
  4. gerrit-acceptance-framework/
  5. gerrit-acceptance-tests/
  6. gerrit-cache-h2/
  7. gerrit-common/
  8. gerrit-elasticsearch/
  9. gerrit-extension-api/
  10. gerrit-gpg/
  11. gerrit-gwtdebug/
  12. gerrit-gwtexpui/
  13. gerrit-gwtui/
  14. gerrit-gwtui-common/
  15. gerrit-httpd/
  16. gerrit-index/
  17. gerrit-launcher/
  18. gerrit-lucene/
  19. gerrit-main/
  20. gerrit-oauth/
  21. gerrit-openid/
  22. gerrit-patch-commonsnet/
  23. gerrit-patch-jgit/
  24. gerrit-pgm/
  25. gerrit-plugin-api/
  26. gerrit-plugin-gwtui/
  27. gerrit-prettify/
  28. gerrit-reviewdb/
  29. gerrit-server/
  30. gerrit-sshd/
  31. gerrit-test-util/
  32. gerrit-util-cli/
  33. gerrit-util-http/
  34. gerrit-util-ssl/
  35. gerrit-war/
  36. lib/
  37. plugins/
  38. polygerrit-ui/
  39. ReleaseNotes/
  40. tools/
  41. website/
  42. .bazelproject
  43. .editorconfig
  44. .git-blame-ignore-revs
  45. .gitignore
  46. .gitmodules
  47. .mailmap
  48. .pydevproject
  49. BUILD
  50. COPYING
  51. INSTALL
  52. README.md
  53. SUBMITTING_PATCHES
  54. version.bzl
  55. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.