| commit | 12c87c7b78358d5eb7f1bfca2a13e677e7786ba3 | [log] [tgz] |
|---|---|---|
| author | Patrick Hiesel <hiesel@google.com> | Mon Sep 03 13:19:08 2018 +0200 |
| committer | Patrick Hiesel <hiesel@google.com> | Fri Sep 07 15:14:37 2018 +0200 |
| tree | c43b94d138644bf3d3ddd2be449caa343e130753 | |
| parent | 460a3f3c3567edeb2178a3a5cc2afb2d2c32af04 [diff] |
Add config and rule to ignore self approval on labels A frequently used Prolog rule is to ignore self approvals when evaluating labels. The simple-submit-rules plugin has created such a rule in Java instead of Prolog. All of the other label functions are handled directly in core so it seems like a good fit, to also just port this one into Gerrit core given that it is used quite often. The new rule gets added as a separate rule so that we grow the SubmitRules implementations more atomically (instead of just adding it to DefaultRule). We add tests that are mainly also just ported from simple-submit-rules. Besides BUILD file and reference changes, the code was migrated to use Flogger and we are more indicative to the user in case the uploader is the only one who approved the change by adding an additional requirement. The rule uses the uploader to make it easier to explain it to users. Basing it on the author would come with the confusion that when you cherry pick a change, you can self approve in case the author of the original patch set was someone else. Basing it on the change owner would mean you can hijack any change by uploading a patch set to submit self-reviewed code. Change-Id: I78b97f60ca1bb4aaf5386103c9228f76974feea4
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.