Google Git
Sign in
gerrit / gerrit / 11cfda8dff467c01ccc6ed1b77f1b9edfba08924
commit11cfda8dff467c01ccc6ed1b77f1b9edfba08924[log] [tgz]
authorDavid Pursehouse <dpursehouse@collab.net>Thu Dec 13 10:44:00 2018 +0900
committerDavid Pursehouse <dpursehouse@collab.net>Thu Dec 13 16:05:09 2018 +0900
treea20df66f12689b91739baa5486dd85ac9012d00b
parent368419410bb54fb8b5fac5d5f84f26a880948b56 [diff]
ReceiveCommits: Fix setting [PRIVATE] and [WIP] for updated changes

When the private and/or work-in-progress state of a change is modified
by pushing for review using any of the %private, %remove-private, %wip
or %ready options, the change notes of the updated changes do not have
the new status. To work around this, the new private/WIP state is set
by checking for the relevant flags in the magic branch.

When none of the private/WIP options are given, i.e. the states are not
being set on push, the states are detected from the change notes of the
updated changes, which contain the current (correct, unchanged) states.

In the latter situation, the states are set from the notes of the first
updated change, but then reused for all subsequent updated changes. As
a result, if the first updated change is private, all subsequent changes
will also be reported with the [PRIVATE] suffix even when they are not
actually private. The same occurs for the [WIP] suffix.

Fix this by reevaluating the private and wip states for each updated
change.

Bug: Issue 9024
Change-Id: Ia9cec72cbc5d8820cd788f50239d19df6ee6f1dd
1 file changed
tree: a20df66f12689b91739baa5486dd85ac9012d00b
  1. .settings/
  2. contrib/
  3. Documentation/
  4. gerrit-acceptance-framework/
  5. gerrit-acceptance-tests/
  6. gerrit-cache-h2/
  7. gerrit-cache-mem/
  8. gerrit-common/
  9. gerrit-elasticsearch/
  10. gerrit-extension-api/
  11. gerrit-gpg/
  12. gerrit-gwtdebug/
  13. gerrit-gwtexpui/
  14. gerrit-gwtui/
  15. gerrit-gwtui-common/
  16. gerrit-httpd/
  17. gerrit-index/
  18. gerrit-launcher/
  19. gerrit-lucene/
  20. gerrit-main/
  21. gerrit-oauth/
  22. gerrit-openid/
  23. gerrit-patch-commonsnet/
  24. gerrit-patch-jgit/
  25. gerrit-pgm/
  26. gerrit-plugin-api/
  27. gerrit-plugin-gwtui/
  28. gerrit-prettify/
  29. gerrit-reviewdb/
  30. gerrit-server/
  31. gerrit-sshd/
  32. gerrit-test-util/
  33. gerrit-util-cli/
  34. gerrit-util-http/
  35. gerrit-util-ssl/
  36. gerrit-war/
  37. lib/
  38. plugins/
  39. polygerrit-ui/
  40. ReleaseNotes/
  41. tools/
  42. website/
  43. .bazelproject
  44. .bazelrc
  45. .editorconfig
  46. .git-blame-ignore-revs
  47. .gitignore
  48. .gitmodules
  49. .mailmap
  50. .pydevproject
  51. 0001-Replace-native-http-git-_archive-with-Skylark-rules.patch
  52. BUILD
  53. COPYING
  54. INSTALL
  55. README.md
  56. SUBMITTING_PATCHES
  57. version.bzl
  58. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.