commit | 11bff0a6c66e6665ad68ad4f0d1fec4cfd5e7090 | [log] [tgz] |
---|---|---|
author | Wyatt Allen <wyatta@google.com> | Tue Sep 27 11:37:20 2016 -0700 |
committer | Wyatt Allen <wyatta@google.com> | Mon Oct 17 13:17:53 2016 -0700 |
tree | 94ba33b46455e7533d591bef72df5e054627dad5 | |
parent | e47fe47537589df30c7851c026a3d32c2efe1c91 [diff] |
Refactor email inline comments as template data Previously, the inline comment section of comment emails was constructed by a set of Java methods in the CommentSender class. The comments were built into a large string containing file groupings, file URLs, file quotations, patch set IDs, line numbers, parent comment messages, and comment messages formatted together. For text emails, this string can be merely included directly in the email body, and was provided to the templates under the `inlineComments` key. With this change, CommentSender is modified to model the inline comments information into a list of groups, organized identically to the grouping found in the `inlineComments` string. These groups are provided to the Soy template as a hierarchical list of maps under the `commentFiles` key. The template now loops over this data, recreating the same grouped comment list format. The `getInlineComments` method is preserved for VTL support, and is refactored to use the same group data. Change-Id: I8816f349abf2d1c397177a0d3c105835a5b228bf
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.