| commit | 11924d57021d5d9e81323b418ddd8d11de15328c | [log] [tgz] |
|---|---|---|
| author | Tao Zhou <taoalpha@google.com> | Wed Dec 18 13:59:10 2019 +0100 |
| committer | Tao Zhou <taoalpha@google.com> | Thu Dec 19 12:59:24 2019 +0000 |
| tree | 23cd05aa257a0f0ee88d7d20f041ea08719777d8 | |
| parent | 6c00f489db720f9d960c6b65d3e504d129122bbc [diff] |
Fix parse error from repo settings page Polymer 2 will run computed methods with `undefined` value and `JSON.parse` will throw error for that. Change-Id: Ie9282269e912ec571b7f2b6f04d8914f4df34100 (cherry picked from commit b9190ca51ef8e3094360d27eed661cd787166d70)
diff --git a/polygerrit-ui/app/elements/admin/gr-repo-plugin-config/gr-repo-plugin-config.js b/polygerrit-ui/app/elements/admin/gr-repo-plugin-config/gr-repo-plugin-config.js index 883a4e1..bfa8832 100644 --- a/polygerrit-ui/app/elements/admin/gr-repo-plugin-config/gr-repo-plugin-config.js +++ b/polygerrit-ui/app/elements/admin/gr-repo-plugin-config/gr-repo-plugin-config.js
@@ -71,7 +71,10 @@ return editable === 'false'; }, - _computeChecked(value) { + /** + * @param {string} value - fallback to 'false' if undefined + */ + _computeChecked(value = 'false') { return JSON.parse(value); },