commit | 115ecd224b8a90d2c5ebe9e3f097f9a9a88b5e67 | [log] [tgz] |
---|---|---|
author | David Pursehouse <david.pursehouse@sonymobile.com> | Fri Mar 11 13:16:42 2016 +0900 |
committer | David Pursehouse <david.pursehouse@sonymobile.com> | Fri Mar 11 11:06:13 2016 +0000 |
tree | b8798ee263619b9f704943b87ba767376fe20cdf | |
parent | cacac00870e75b578253f11c10042e3af4c45a82 [diff] |
RevisionIT: Extend 'submit' and 'submit on behalf of' tests The existing test named 'submitOnBehalfOf' tests the case where the user does not have permission. Rename it to 'submitOnBehalfOfNotPermitted' to better reflect its purpose. Use ExpectedException rather than the 'expected' argument on the @Test annotation, and add an additional check for the expected message. Add a new test 'submitOnBehalfOf' that tests the case where the user does have permission. Add a new test that tests the case where the 'on behalf of' user is not a valid account. Add an assertion in the submit test that the change was merged. There are still some cases that don't have coverage, but they can be done in separate commits later: - Caller does not have submit permission - Destination branch does not exist - Destination branch is not visible to on-behalf-of user - Revision is not the current revision Change-Id: Iad0df1b9262b9031293c7f2b42eb5fd1a9c95ecb
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.