commit | e75790e74cea9d60f6b09cc13eeaf0f910734764 | [log] [tgz] |
---|---|---|
author | Alice Kober-Sotzek <aliceks@google.com> | Fri Oct 20 14:59:50 2017 +0200 |
committer | David Pursehouse <dpursehouse@collab.net> | Sat Oct 21 01:54:03 2017 +0000 |
tree | e2ac4aee520db815c4f623fc0633f0ae7780c449 | |
parent | f5f89beb70bb8b40be89971e253e0734d9dbf535 [diff] |
Fix check for group index in GroupCacheImpl.ByIdLoader The group index is added to the GroupIndexCollection at some point during startup. When the constructor of a class is called via Guice, we cannot be sure that the GroupIndexCollection already has the group index. This situation becomes obvious when we run our tests: Without this change, we never lookup the groups from the index in GroupCacheImpl.ByIdLoader during test execution. The fix is simple: We test for the existence of the group index right before we try to access it. Change-Id: Ic467bb1805d6058a7ae770e81e86ef59df81742a (cherry picked from commit fccc9851760b93c7d6e3772435c045848988b6bf)
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.