Google Git
Sign in
gerrit / gerrit / 1070800279e56f465ffb6ad0e792092166ec82aa
commit1070800279e56f465ffb6ad0e792092166ec82aa[log] [tgz]
authorKamil Musin <kamilm@google.com>Wed Mar 27 15:22:56 2024 +0100
committerKamil Musin <kamilm@google.com>Thu Mar 28 11:13:48 2024 +0100
treeadfc869605d0e305d6bd5d6f0f82773e114088f9
parentdfdd715e31db256dfba48239f83f9b8da4bc243f [diff]
Use switchMap when requesting change comments

Currently there is a race condition if the changeNum changes several
times in the short sequence. With introduction of switchMap, only the
latest change will end up updating the comments. Preventing the issues
where the comments are shown for the wrong change.

Additionally combine multiply separate modifyState calls. Each
individual call adds a an async boundary due to
https://cs.opensource.google/gerrit/gerrit/gerrit/+/master:polygerrit-ui/app/models/base/model.ts;l=49
Which makes it hard to reason about the state consistency.

Race condition is also possible between a manual call to
reloadAllComments (happens on reply), and RxJS subscribe based paths.
In order to avoid this issue, we introduce reloadAllComments$ manual
trigger. This way manual reload request will be resolved via the same
switchMap mechanism. This means that reloadAllComments no longer returns
a promise that resolves on completion, but awaiting that promise was not
used in the codebase.

gr-message-list_test needed fixing, since the reloading requires
changeNum to be set in the comments-model. Therefore we update it to
interact with ChangeViewModel.

As a bonus some documentation comments have been added to
comments-model.ts

Google-Bug-Id: b/328632912
Release-Notes: skip
Change-Id: Ib32318f12fa7c8812d3587bbf780d45816f8aff1
2 files changed
tree: adfc869605d0e305d6bd5d6f0f82773e114088f9
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .pydevproject
  30. .zuul.yaml
  31. BUILD
  32. COPYING
  33. INSTALL
  34. Jenkinsfile
  35. MODULE.bazel
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. web-dev-server.config.mjs
  41. WORKSPACE
  42. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.