Migrate from custom logic to DiffFormatter in sticky approval messages Currently, we post a change message and send an email after submitting a change that was approved via a sticky approval. We had custom logic to compute the diff between the latest approved patch-set and the submitted patch-set. It's better to not use custom logic, but rather use DiffFormatter. The advantage of custom logic was better UX, but we kept the better UX by removing non user friendly lines from the DiffFormatter results. The advantages of moving to DiffFormatter: 1. Less maintenance. 2. We get out-of-the-box context of 3 lines in the diff, which was missing from the custom logic. The disadvantage is that we're not using the diff cache. However, it's unlikely for the requested diff to be available in the cache anyway (since we need specifically the diff between the latest approved patch-set and the submitted patch-set). Also, it's a one time calculation which hopefully doesn't touch many files. Change-Id: If756370dd0e1fd60ac112891d6854b5cec698be8
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.