| commit | 0f8480d2e5828fb2e6721d19431b966f5875cd72 | [log] [tgz] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Tue Oct 20 15:28:28 2015 -0400 |
| committer | Dave Borowitz <dborowitz@google.com> | Fri Oct 23 10:56:44 2015 -0700 |
| tree | 13578c8a47391506b071fd44eec3796260220a18 | |
| parent | 674844faf6a725bffeeef3bbd011dd404eb6aac3 [diff] |
PublicKeyChecker: Fix revocation check (mostly) Bouncy Castle's isRevoked() method is so dumb as to be harmful: it only checks whether there is a revocation packet in the key, without doing any sort of validity checks on the packet. Improve the check by verifying the signature against the key that provided it, and for non-self-signatures, verifying that the signer is an authorized revocation key. This requires always passing in a store to any PublicKeyChecker. However, we still have the same initialization order problem as before, where a store is not always available at PublicKeyChecker creation, in particular in the PushCertificateChecker codepath. Argument precondition checks are the best we can do. Also add a convenience method to GerritPublicKeyChecker.Factory for the very common case (particularly in tests) where we do have both an expected user and a store. Change-Id: Id15714f0395a200fcb33fb199c57355b860187a3
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build all
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.