commit | a300b1d00e8978b56e18b7ddc8c958fd9602266a | [log] [tgz] |
---|---|---|
author | Youssef Elghareeb <ghareeb@google.com> | Fri Aug 27 13:34:57 2021 +0200 |
committer | Youssef Elghareeb <ghareeb@google.com> | Thu Sep 02 09:47:47 2021 +0200 |
tree | 411438061669ca7ae1dfd0a6018c3fa34bf6cb80 | |
parent | afb2cd0b0bd1f07a23982d4456e5e668c5617df2 [diff] |
SubmitRecord: Add a field with the rule name that created the record We need this field since we're going to wrap the existing submit records into submit requirements to be served with other submit requirements from project.config. We need this for a couple of reasons: 1) For submit records containing one or more labels, we want to create submit requirement results per label of the form `label:$name=$rule_name`. For submit records containing no labels, we will create one submit requirement result whose name = rule name. 2) We want to identify the submit record created by the default submit rule. We need to inspect the label function so that we can create a proper blocking condition accordingly. For example, for a label with a MAX_WITH_BLOCK function we want to create the blocking condition as `label:$name=MAX -label:$name=MIN`. We write the ruleName field in SubmitRequirementsEvaluator after evaluating each submit rule. Rule name has the form of '$plugin_name~$ruleClassName' for example 'gerrit~DefaultSubmitRule'. We also update the storage of submit records in NoteDb to include the rule name field. Change-Id: I3f08f189dd154a36a84ebdd7aec6a553ce6a044c
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.