Only display assignee in change list if assigned Without this fix, unassigned changes will have an empty grey circle in the assignee column. Change-Id: I11d54da5ed60145cf722ddf031d2254eaa0b91e1
diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.html b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.html index 83a4362..a2c7853 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.html +++ b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.html
@@ -139,7 +139,9 @@ </td> <td class="cell assignee" hidden$="[[isColumnHidden('Assignee', visibleChangeTableColumns)]]"> - <gr-account-link account="[[change.assignee]]"></gr-account-link> + <template is="dom-if" if="[[change.assignee]]"> + <gr-account-link account="[[change.assignee]]"></gr-account-link> + </template> </td> <td class="cell project" hidden$="[[isColumnHidden('Project', visibleChangeTableColumns)]]">
diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.html b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.html index cd07b5a..243a8ab 100644 --- a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.html +++ b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.html
@@ -186,5 +186,16 @@ const elementClass = '.bad'; assert.isNotOk(element.$$(elementClass)); }); + + test('assignee only displayed if there is one', () => { + assert.isNotOk(element.$$('.assignee gr-account-link')); + element.change = { + assignee: { + name: 'test', + }, + }; + flushAsynchronousOperations(); + assert.isOk(element.$$('.assignee gr-account-link')); + }); }); </script>