commit | 5c13722d00cf40e13988f1401c7c1b034b72c977 | [log] [tgz] |
---|---|---|
author | Edwin Kempin <ekempin@google.com> | Wed Aug 07 14:59:20 2019 +0200 |
committer | Edwin Kempin <ekempin@google.com> | Mon Aug 12 09:21:53 2019 +0200 |
tree | e28fcfb5d3ddfbca75feb718f3af825387d34592 | |
parent | 4bc54e5fdc20c402be1521b1b8a0c8b28d2a5381 [diff] |
SubmitRule: Remove SubmitRuleOptions arg from evaluate method The SubmitRuleOptions contain mostly Prolog-specific settings and are only used by the PrologRule. All other implementation of SubmitRule ignore the options, hence the interface is cleaner without the SubmitRuleOptions arg. All Prolog-specific settings from SubmitRuleOptions are now moved into a new PrologOptions AutoValue class that is only used by PrologRule and PrologRuleEvaluator. There are only 2 variants of the prolog options that are used, one for checking the submittability of changes against the Prolog rules that are configured in the project, one for testing Prolog rules that are passed in into the TestSubmitRule / TestSubmitType REST endpoints. For the first case we go through SubmitRuleEvaluator. In this case we pass no options to PrologRule, but PrologRule just uses the default options which work for production. For the second case we invoke PrologRule directly and pass in the dry run options. SubmitRuleOptions contains only a single option now (allowClosed), but this options is checked before submit rules are invoked. Hence this option is not relevant for SubmitRule implementations. The SubmitRuleOptions that are used for computing submit records that are stored in the change index (SUBMIT_RULE_OPTIONS_LENIENT and SUBMIT_RULE_OPTIONS_STRICT) are not changed since they only use the one field in SubmitRuleOptions that is still there (allowClosed). Change-Id: Ifa474e2c16fee02f52b6e6339bdf980b8f4f3a50 Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.