commit 0ee2e98606e8279b7213992c006f919467fc858f
author David Pursehouse <david.pursehouse@sonymobile.com> Mon Dec 16 14:15:20 2013 +0900
committer David Pursehouse <david.pursehouse@sonymobile.com> Mon Dec 16 14:18:57 2013 +0900
tree c4524e2d4b85342036b59fdad1b0525d2c56f287
parent d26a0a26a5489a7f876cf757611f6639d4517473

Prevent possible NPE in AuthorRevision.equals

Add check for the given object being an instance of the
expected class.

This clears a warning from Findbugs.

Change-Id: I097f8894239f04804a0038b504eccd8e2374b07a

gerrit-gwtui/src/main/java/com/google/gerrit/client/change/History.java

diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/History.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/History.java
index c2ecb4c..c461ae9 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/History.java
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/History.java
@@ -210,6 +210,9 @@
 
     @Override
     public boolean equals(Object o) {
+      if (!(o instanceof AuthorRevision)) {
+        return false;
+      }
       AuthorRevision b = (AuthorRevision) o;
       return author == b.author && revision == b.revision;
     }