Add AutoValue classes for Preferences

AccountState is a cached entity that contains user preferences. Any
cached entity should only hold onto immutable objects and be immutable
itself. This commit addds AutoValue classes for user preferences that
replace the *Info objects in AccountState.

For now, the change is internal to AccountState only and the rest of the
code is not touched. In the future, we might keep *Info classes only on
the API level and use the immutable AutoValue representation in the
inner works of Gerrit. Any such change can be an interative follow up.

We use Optionals for now to express that any field can be unset. The
alternative here is @Nullable. For now, Optional seems to be the better
choice as it makes callers explicitly aware of that fact. This can be
adapted any time.

The alternative to making these classes AutoValues would be either to
defensively copy them when storing and retrieving them from AccountState
or using Protobuf. In the former case, the required boiler plate would
be similar to what is implemented here as we would need copy methods as
well as equals and hashCode. The latter case is very similar to
AutoValues, but we don't pass protos around in Gerrit until now.

This change explicitly resets the user in two test cases as the test
suite holds on to an IdentifiedUser which in turn holds on to an
AccountState. Prior to this commit, we would mutate these values when
updating the preferences. With the new mechanism, that is not the case
anymore (this is the correct state of the world).

Change-Id: I8ab306e8d1d8f5d1d9ce3209aaa600347ed47e5c
5 files changed
tree: 9ae6f7b5d8e9136afa46148fa7ecda76bd944558
  1. .settings/
  2. antlr3/
  3. contrib/
  4. Documentation/
  5. e2e-tests/
  6. java/
  7. javatests/
  8. lib/
  9. plugins/
  10. polygerrit-ui/
  11. prolog/
  12. prologtests/
  13. proto/
  14. resources/
  15. tools/
  16. webapp/
  17. .bazelproject
  18. .bazelrc
  19. .bazelversion
  20. .editorconfig
  21. .git-blame-ignore-revs
  22. .gitignore
  23. .gitmodules
  24. .gitreview
  25. .mailmap
  26. .pydevproject
  27. BUILD
  28. COPYING
  29. INSTALL
  30. package.json
  31. README.md
  32. SUBMITTING_PATCHES
  33. version.bzl
  34. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.