commit 0c8a8002201a93256cd16f79e73169eaa70f6ca3
author Edwin Kempin <ekempin@google.com> Fri Sep 01 10:55:59 2023 +0000
committer Edwin Kempin <ekempin@google.com> Fri Sep 01 10:59:17 2023 +0000
tree e681cd1e0da5d37d15468396c897c41e7100d900
parent bb2a4925ad733e5a448bfcba3c2db515218a4a43

Set ImpossibleNullComparison ErrorProne pattern to ERROR

Fix the ImpossibleNullComparison ErrorProne pattern issues and set it to
ERROR level to prevent new instances of this.

Release-Notes: skip
Change-Id: I97ba03090806799c60ae05730acf5a9a4770610a
Signed-off-by: Edwin Kempin <ekempin@google.com>

java/com/google/gerrit/lucene/LuceneChangeIndex.java

diff --git a/java/com/google/gerrit/lucene/LuceneChangeIndex.java b/java/com/google/gerrit/lucene/LuceneChangeIndex.java
index 215276c..6718e36 100644
--- a/java/com/google/gerrit/lucene/LuceneChangeIndex.java
+++ b/java/com/google/gerrit/lucene/LuceneChangeIndex.java
@@ -555,7 +555,7 @@
     }
 
     for (SchemaField<ChangeData, ?> field : getSchema().getSchemaFields().values()) {
-      if (fields.contains(field.getName()) && doc.get(field.getName()) != null) {
+      if (fields.contains(field.getName())) {
         field.setIfPossible(cd, new LuceneStoredValue(doc.get(field.getName())));
       }
     }

tools/BUILD

diff --git a/tools/BUILD b/tools/BUILD
index 70d4315..e92d731 100644
--- a/tools/BUILD
+++ b/tools/BUILD
@@ -189,7 +189,7 @@
         "-Xep:ImmutableAnnotationChecker:ERROR",
         "-Xep:ImmutableEnumChecker:ERROR",
         "-Xep:ImmutableModification:ERROR",
-        "-Xep:ImpossibleNullComparison:WARN",
+        "-Xep:ImpossibleNullComparison:ERROR",
         "-Xep:Incomparable:ERROR",
         "-Xep:IncompatibleArgumentType:ERROR",
         "-Xep:IncompatibleModifiers:ERROR",