Error Prone: Enable and fix ImmutableEnumChecker
* Mark some enums using @Immutable from Error Prone (and also import
that library).
* Suppress one usage of an effectively-immutable JGit class which we
don't control.
* Fixing ReviewerStateInternal to store a String internally rather than
a FooterKey. FooterKey is actually not immutable: it has a package-
private byte array field. Keep returning FooterKey from the interface
for type safety; given that one method was already constructing a new
FooterKey dynamically on every invocation, and that this class is
primarily used for constructing ChangeUpdates, this shouldn't be a
performance issue.
Change-Id: Ieb7ee10e9be39184cff7e0d1d18ff6b433016b31
diff --git a/WORKSPACE b/WORKSPACE
index 836c374..7aa09e2 100644
--- a/WORKSPACE
+++ b/WORKSPACE
@@ -186,6 +186,12 @@
sha1 = "94ad16d728b374d65bd897625f3fbb3da223a2b6",
)
+maven_jar(
+ name = "error-prone-annotations",
+ artifact = "com.google.errorprone:error_prone_annotations:2.3.3",
+ sha1 = "42aa5155a54a87d70af32d4b0d06bf43779de0e2",
+)
+
FLOGGER_VERS = "0.4"
maven_jar(
