| commit | 231e698ab65e990ba2016ec632efb098af9fd9d8 | [log] [tgz] |
|---|---|---|
| author | David Ostrovsky <david@ostrovsky.org> | Tue May 28 19:49:03 2024 +0200 |
| committer | David Ostrovsky <david@ostrovsky.org> | Wed May 29 10:48:27 2024 +0000 |
| tree | 8cbec2774c5e8ddfe85db8e8b714c4e489450b61 | |
| parent | e3bbaac57baa5e4bb529b2ab294306023e02e3fe [diff] |
Bazel: Don't build protobuf from the source Gerrit is pure java project. Given that it depends on Google protobuf, and given that Bazel was using @com_google_protobuf toolchain that was built from source, this project ended up bulding the Google protobuf from source. Compiling protoc from source requires a functional C++ toolchain, which is a burden for projects that have no C++ code. Also, Bazel does not ship with a hermetic toolchain, so that it is possible that for many Gerrit developers and contributors the Bazel build is inherently broken. In addition, building protobuf from source made OS upgrades difficult because of the incompatibilities between the source code and the latest XCode versions. That changed in Bazel 7.x release, with the new and shiny option: --incompatible_enable_proto_toolchain_resolution, that allow to register prebuilt protoc toolchains. In addition rules_proto have added support for prebuilt toolchains in context of this tracking issue: [1]. In this change we use toolchains_protoc project to consume predefined protobuf toolchains: [2]. As the side effect of this change we have to consume protobuf-java ourself and not transitively through standard @com_google_protobuf toolchain. Given that Google protobuf is internal Google project and all released versions already available within Google, we add the new dependency to tools/nongoogle.bzl to exempt the updates for it from the Library-Compliance label. Now, that we stop building protobuf from source, we can remove C++ options in .bazelrc as well. [1] https://github.com/bazelbuild/rules_proto/issues/179 [2] https://github.com/aspect-build/toolchains_protoc Release-Notes: Use prebuilt protobuf toolchain to avoid building protoc from source Change-Id: I27975879819c4b632682990474ce88737f722d9a
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.