| commit | 0b3affa4e2f464a9213f79abbd3181636e7b9b2d | [log] [tgz] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Fri Jun 16 10:22:02 2017 -0400 |
| committer | David Ostrovsky <david.ostrovsky@gmail.com> | Wed Sep 19 18:22:11 2018 +0000 |
| tree | 0f371cff7bf5f0f91764fd54f333db1348a9e229 | |
| parent | 08f5fd823abe87988a032d25fca0e3f11cb29bba [diff] |
IdString: Don't compare equal to strings Object#equals is supposed to define an equivalence relation[1][2]. This includes the property of symmetry: a.equals(b) if and only if b.equals(a). The old implementation of IdString#equals was asymmetrical: it returned true when comparing to a String with the same urlencoded value, but of course String#equals will always return false when comparing to an IdString. Fix IdString#equals to only compare equal to other IdStrings. It's trivial and readable to fix the few usages in Gerrit core. Since this method is part of the extension API, it's possible (though personally I think highly unlikely) that plugins in the wild are depending upon the current behavior, similar to how core was. Breakages may be subtle, if for example callers were trying to look up Strings in a Map<IdString, V>. However, it's worth noting that the asymmetric behavior of equals meant that plugins were _already_ in for subtly confusing or broken behavior. At a minimum need to mention this behavior change in release notes. [1] https://en.wikipedia.org/wiki/Equivalence_relation [2] Effective Java, Item 8: "Obey the general contract when overriding equals" Change-Id: I9d79b90640ea095b71803185d581cda77b93964e (cherry picked from commit e24bb8be8df1084406d2900c4bd0a7b51bb811d1)
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.