commit | 0a503edfdd17b0cab7d12862d1e9d3dc63caa082 | [log] [tgz] |
---|---|---|
author | Jean-Jacques Lafay <jeanjacques.lafay@gmail.com> | Sun Oct 02 11:35:29 2016 +0200 |
committer | Jean-Jacques Lafay <jeanjacques.lafay@gmail.com> | Sun Oct 02 09:38:18 2016 +0000 |
tree | 738ec3be568f5866e176181ddae17b507c514c2e | |
parent | b224bf9d4ad30e4259c20bc22ad2d261f785dc51 [diff] |
Fix double Repository.close() in MergeOp The call to closeRepository() from the finally block on line 461 doubles up with the "normal" call on line 446, so we have to make sure not to close() the repo twice. This resulted in the counter for the repo to regularly reach exactly 0, when all cached data are flushed, and we suffer a serious performance hit. Once enough changes have been merged however (especially more than the number of indexing threads that kick in immediately after a successful merge to check for mergeability), the counter stays consistently negative and performances return to normal. Note that this has been fixed in 2.13 as a side-effect of 4b1e2a460. Change-Id: I49181f0bff7b57d83bfad4ba225d1266ee545b35
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.