commit | 095394c06995a8e3236cee65f4583b19b85bd631 | [log] [tgz] |
---|---|---|
author | Dave Borowitz <dborowitz@google.com> | Tue May 01 10:50:47 2018 -0400 |
committer | Dave Borowitz <dborowitz@google.com> | Mon May 14 14:26:50 2018 -0700 |
tree | cbd7ff3571dfeda540153f1cf7ed1d53dba9400c | |
parent | e6930d73b01d68f265a78dbbb3ecc449b0b77f55 [diff] |
Add tests for fields declared in types with custom serializers When the set of fields changed, it's a very good sign that something needs to change in the serializer implementation, or at least bumping the version number in the CacheMoule. Add a simple test utility that maps declared field names to types, and list the expected types explicitly in each of the relevant tests. This simple mechanism can't catch everything, for example: * If the serializer implementation changes for an existing type in an incompatible way, without altering any fields. In this case, the {key,value}Serializer in the CacheModule will change, so hopefully a reviewer will notice and ask the author to bump the version as well. * If semantics of individual fields change without changing the type, such as making a field newly @Nullable. But it's much better than nothing. Change-Id: I51e60b83f9c3291d2f8f9ac19ce0192678211676
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.