| commit | 077f7adc833a22ab650b57bf88849827c77fc51e | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Fri May 06 09:52:52 2022 +0200 |
| committer | Edwin Kempin <ekempin@google.com> | Fri May 06 13:26:21 2022 +0200 |
| tree | 1ec5cff43a2a8d9b2292e9817bac75d668b81044 | |
| parent | bb47906541362426d7925a330e30a77dfff1b8d3 [diff] |
ReplaceOp: Extract async email sending and make it thread-safe Follow the example of the EmailReviewComments to extract the email sending for new patch sets in ReplaceOp into a separate class. This may allow us later to reuse this code in PatchSetInserter. Using non-thread-safe variables in background threads that have been created in another thread can lead to synchonization issues and is not safe (also see change If2e8c7c4d). Create a dedicated Runnable class to send the asynchronous email so that we can document this and control better that only thread-safe (e.g. immutable) objects are passed into it. With this change we stop passing in non-thread-safe, e.g. mutable, objects like ChangeNotes (contains a mutable Change instance), RepoView and MailRecipients. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: Ie0b41db6af7940b2e516f7c311b7a541a4b3bc4e Release-Notes: skip
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.